Differenciate signaturePrototype and inheritancePrototype#4945
Open
VincentLanglet wants to merge 5 commits intophpstan:2.1.xfrom
Open
Differenciate signaturePrototype and inheritancePrototype#4945VincentLanglet wants to merge 5 commits intophpstan:2.1.xfrom
VincentLanglet wants to merge 5 commits intophpstan:2.1.xfrom
Conversation
Collaborator
|
This pull request has been marked as ready for review. |
staabm
reviewed
Feb 16, 2026
|
|
||
| /** | ||
| * @return array{ExtendedMethodReflection, ClassReflection, bool}|null | ||
| * Finds the prototype method that a class method should be validated against. |
Contributor
There was a problem hiding this comment.
since we started describing the return type, I think it would be usefull to also describe what the bool means
staabm
reviewed
Feb 16, 2026
Contributor
staabm
left a comment
staabm
left a comment
There was a problem hiding this comment.
I can't really judge the fix, but fixing 3 bugs at once seems to prove it looks good :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#11067
Closes phpstan/phpstan#12830
Closes phpstan/phpstan#12272